Conversation
Member
JustinPrivitera
left a comment
JustinPrivitera
left a comment
There was a problem hiding this comment.
Do all the tests pass? Or maybe we have no tests for this case? I know you said this worked with sample data that you used.
Comment on lines
+2484
to
+2485
| utils::join_path(conduit_fmt::format("{}",i), | ||
| entry_path); |
Member
There was a problem hiding this comment.
Same thing here about using conduit_fmt to make a string out of an integer being overkill
Member
Author
There was a problem hiding this comment.
not sure it matters much for these cases - but lore states that fmt is faster than std::to_string()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.