Remove unused current_device in CudaAdviseOperation #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes dead code from the CudaAdviseOperation::apply method by eliminating an unused current_device variable and its associated cudaGetDevice call with error handling. The removed code was only present in the CUDA Runtime version 13.0+ code path and had no effect on functionality since the variable was never used.
Key Changes
- Removed unused
current_devicevariable declaration - Removed
cudaGetDevicecall and its error handling that populated the unused variable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
davidbeckingsale
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm so awesome I did this all by myself