setuptools-git-version not needed #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If following instructions here https://ingrid.readthedocs.io/en/latest/installation.html then only setuptools is available, not setuptools-git-version.
Collaborator
|
I believe that setuptools-git-version was included in the setup.py script in order to be able to install tag-specific versions of INGRID (docs: https://pypi.org/project/setuptools-git-version/). We could indeed do without. Future versioning of the INGRID package would need to be manually set, however. @umansky any preference? |
|
|
||
| setup( | ||
| name='INGRID', | ||
| version_format='{tag}', |
Collaborator
There was a problem hiding this comment.
I believe argument 'version_format' would need to be removed since it seems to be setuptools-git-version specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If following instructions here https://ingrid.readthedocs.io/en/latest/installation.html
then only setuptools is available, not setuptools-git-version.