Skip to content

Conversation

@daboehme
Copy link
Member

Better encapsulates the global static variables in Adiak. Also moves the hash list to the shared object, and uses hash to look up entries by name in the adiak_get_nameval* functions. Fixes #40.

@daboehme daboehme merged commit 0622e86 into llnl:master Sep 23, 2025
3 checks passed
@baallan
Copy link

baallan commented Sep 23, 2025

Thanks for looking into #40.
@daboehme it's a couple of nits, but:

  • it would be nice if strhash here were named strhash_djb2 since that's what it is algorithmically.
  • it would be nice if it was declared as size_t or uint64_t instead of unsigned long; probably size_t. We still have architectures where long is 32 and long long is 64 bit.

@daboehme daboehme deleted the dev/refactor-static-variables branch September 23, 2025 22:44
@daboehme
Copy link
Member Author

Thanks @baallan - I addressed these in #42 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adiak_get_nameval_info linearity

2 participants