test/e2e: migrate from Ensure* to Create* pattern for test isolation#942
Open
sats-23 wants to merge 1 commit intollm-d:mainfrom
Open
test/e2e: migrate from Ensure* to Create* pattern for test isolation#942sats-23 wants to merge 1 commit intollm-d:mainfrom
sats-23 wants to merge 1 commit intollm-d:mainfrom
Conversation
Contributor
|
Unsigned commits detected! Please sign your commits. For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation. |
Collaborator
|
@sats-23 please rebase thanks. |
Replace delete-and-recreate Ensure* helpers with fail-if-exists Create* functions across all e2e test files. This eliminates the illusion that multiple tests can safely share resources and establishes clear single- owner semantics for test resources. Key changes: - Introduce utils.NewTestResourceNames() for unique resource naming - Migrate 59 Ensure* calls to Create* across 7 test files - Consolidate cleanup from scattered DeferCleanup to AfterAll blocks - Enhance BeforeSuite to clean leftover resources from interrupted runs - Add comprehensive documentation and migration guides Each test now owns uniquely-named resources, preventing cross-test mutations and enabling future parallel test execution. The only remaining Ensure* calls are for transient load generation utilities, which are documented as justified exceptions. Signed-off-by: Sathvik <Sathvik.S@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #939
Replace delete-and-recreate Ensure* helpers with fail-if-exists Create* functions across all e2e test files. This eliminates the illusion that multiple tests can safely share resources and establishes clear single- owner semantics for test resources.
Key changes:
Each test now owns uniquely-named resources, preventing cross-test mutations and enabling future parallel test execution. The only remaining Ensure* calls are for transient load generation utilities, which are documented as justified exceptions.