feat(helm): add keda.enabled flag and hpa/keda ownership disable support#906
Draft
HighonAces wants to merge 1 commit intollm-d:mainfrom
Draft
feat(helm): add keda.enabled flag and hpa/keda ownership disable support#906HighonAces wants to merge 1 commit intollm-d:mainfrom
HighonAces wants to merge 1 commit intollm-d:mainfrom
Conversation
Adds an opt-out mechanism so external platforms (e.g. KServe) can exclusively own HPA and KEDA ScaledObject sub-resources for a target Deployment, while WVA continues to emit wva_desired_replicas metrics. Changes: - values.yaml: add keda stanza (enabled: false by default) with full ScaledObject configuration; add ownership comments to hpa block - templates/hpa.yaml: add doc comment pointing to KServe guide - templates/keda.yaml (new): renders a keda.sh/v1alpha1 ScaledObject when keda.enabled=true; includes a helm fail guard that rejects hpa.enabled=true+keda.enabled=true simultaneously - tests/hpa_keda_ownership_test.yaml (new): helm-unittest tests for all four ownership combinations - docs/integrations/kserve-integration.md (new): integration guide documenting Phase 1 (KServe owns) and Phase 2 (WVA owns) migration Supported ownership modes: hpa.enabled=true, keda.enabled=false -> HPA only (default) hpa.enabled=false, keda.enabled=false -> no sub-resources (KServe mode) hpa.enabled=false, keda.enabled=true -> KEDA ScaledObject only hpa.enabled=true, keda.enabled=true -> helm error (rejected)
Contributor
Author
Contributor
|
This PR is marked as stale after 21d of inactivity. After an additional 14d of inactivity (7d to become rotten, then 7d more), it will be closed. To prevent this PR from being closed, add a comment or remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-out mechanism so external platforms (e.g. KServe) can exclusively own HPA and KEDA ScaledObject sub-resources for a target Deployment, while WVA continues to emit wva_desired_replicas metrics.
Changes:
Supported ownership modes:
hpa.enabled=true, keda.enabled=false -> HPA only (default) hpa.enabled=false, keda.enabled=false -> no sub-resources (KServe mode) hpa.enabled=false, keda.enabled=true -> KEDA ScaledObject only hpa.enabled=true, keda.enabled=true -> helm error (rejected)