fix(training): bound BulkTrainingRequest entries list size - #78
Open
madhugoutham wants to merge 1 commit into
Open
fix(training): bound BulkTrainingRequest entries list size#78madhugoutham wants to merge 1 commit into
madhugoutham wants to merge 1 commit into
Conversation
Mirror BulkPredictionRequest (max 10000) so oversized POSTs to /add_training_data_bulk fail validation instead of materializing unbounded lists in memory. EPP already caps flushes via MaxSampleSize. Signed-off-by: Madhu Goutham Reddy Ambati <mambati@redhat.com>
|
This PR is marked as stale after 21d of inactivity. After an additional 14d of inactivity (7d to become rotten, then 7d more), it will be closed. To prevent this PR from being closed, add a comment or remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
BulkTrainingRequest.entriesatmin_length=1, max_length=10000BulkPredictionRequest.requestsWhy is this change needed?
/add_training_data_bulkhad no list-size limit; a large POST is fully parsed before per-bucket deques applyMaxSampleSize(default 1000); this adds the same kind of server-side guard prediction already hasHow was this tested?
Checklist
git commit -s) per DCORelated Issues
N/A