nightly: leverage llm-d-modelservice assignment of priorityClassName#135
Open
maugustosilva wants to merge 1 commit intollm-d:mainfrom
Open
nightly: leverage llm-d-modelservice assignment of priorityClassName#135maugustosilva wants to merge 1 commit intollm-d:mainfrom
llm-d-modelservice assignment of priorityClassName#135maugustosilva wants to merge 1 commit intollm-d:mainfrom
Conversation
Version `0.4.9` of `llm-d-modelservice` allows the `priorityClassName` to be assigned directly on relevant kubernetes objects from the get go, therefore obviating the need for complex "patching with `priorityClassName` code we had previously" Initially targeting only `helmfile` workflows. Signed-off-by: maugustosilva <maugusto.silva@gmail.com>
maugustosilva
requested review from
Gregory-Pereira and
clubanderson
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Version
0.4.9ofllm-d-modelserviceallows thepriorityClassNameto be assigned directly on relevant kubernetes objects from the get go, therefore obviating the need for complex "patching withpriorityClassNamecode we had previously"Initially targeting only
helmfileworkflows.IMPORTANT: this should not be merged until we update all guides with commented out
priorityClassNamefor nightly CI/CD tests (llm-d/llm-d#1062)Why is this change needed?
Reduces the need for custom code, increases maintainability and debuggability.
How was this tested?
Checklist
git commit -s) per DCOmake test)make lint)Related Issues