small perf improve in saturation analyzer - #608
Merged
Conversation
Collaborator
|
/ok-to-test |
Contributor
|
🚀 E2E tests triggered by /ok-to-test |
Collaborator
|
@clubanderson, do we know why the OpenShift setup is failing? |
Collaborator
Author
@asm582 I believe @ev-shindin is handling this in #610 |
Contributor
Collaborator
|
/retest |
Contributor
|
🚀 E2E tests triggered by /retest |
asm582
changed the title
biranofer
force-pushed
the
analizer-perf
branch
from
January 21, 2026 16:26
c2b0764 to
c27dd70
Compare
biranofer
force-pushed
the
analizer-perf
branch
from
January 21, 2026 16:35
c27dd70 to
9d372f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In saturation/analyzer.go in AnalyzeModelSaturation(), pass the computed nonSaturatedCount, AvgSpareKvCapacity, AvgSpareQueueLength into isScaleDownSafe(), from them it can compute the re-assignment of load w/o looping over all replicas again.
Related issue #607