馃尡 Update golangci-lint to v2.8.0 - #588
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates golangci-lint from v2.1.6 to v2.8.0 to resolve false positive nil pointer dereference warnings that were blocking PR #424.
Changes:
- Upgrades golangci-lint version in CI workflow
- Resolves staticcheck false positives where
t.Fatal()termination wasn't recognized
Collaborator
|
/ok-to-test |
Contributor
|
馃殌 E2E tests triggered by /ok-to-test |
Collaborator
|
commit needs verified signature @clubanderson |
The previous version (v2.1.6) had false positives with staticcheck not recognizing that t.Fatal() terminates execution, causing spurious "possible nil pointer dereference" warnings in test files. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com>
clubanderson
force-pushed
the
update-golangci-lint-v2.8.0
branch
from
January 14, 2026 17:41
6679043 to
0c508e7
Compare
Contributor
Author
|
@mamy-CS done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t.Fatal()terminates executionContext
PR #424 is blocked by these false positives in
pkg/core/system_test.goandpkg/core/allocation_test.go. The code correctly checks for nil and callst.Fatal()which stops execution, but the older linter version doesn't understand this control flow.Test plan