cleanup: remove collector v1 - #560
Merged
Merged
Conversation
Signed-off-by: Lionel Villard <villard@us.ibm.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a comprehensive cleanup by removing the deprecated collector v1 implementation and related code. The changes streamline the codebase by eliminating obsolete components that have been superseded by the v2 collector architecture.
Key Changes
- Removed entire collector v1 implementation including Prometheus collector, cache, and configuration
- Deleted deprecated optimizer and model engine v1 code
- Moved
CacheConfigandFreshnessThresholdstypes frominternal/collector/configtointernal/configpackage - Removed
MetricsCollectorinterface and related methods frominternal/interfaces - Cleaned up extensive test suites for deleted components
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/optimizer/suite_test.go | Removed test suite for deprecated optimizer v1 |
| internal/optimizer/optimizer_test.go | Removed optimizer v1 tests |
| internal/optimizer/optimizer.go | Removed optimizer v1 engine implementation |
| internal/interfaces/metrics_collector.go | Removed MetricsCollector interface (v1) |
| internal/engines/saturation/engine.go | Removed deprecated CollectMetricsForSaturationMode method |
| internal/engines/model/engine.go | Removed placeholder model engine v1 |
| internal/config/prometheus.go | Added CacheConfig and FreshnessThresholds types (moved from collector/config) |
| internal/collector/prometheus/* | Removed entire prometheus collector v1 package and tests |
| internal/collector/config/* | Removed config package (types moved to internal/config) |
| internal/collector/cache/* | Removed cache implementation used by v1 |
| internal/collector/factory.go | Removed factory for creating v1 collectors |
| internal/collector/collector.go | Removed deprecated functions (ValidateMetricsAvailability, AddMetricsToOptStatus, FixValue) |
Collaborator
|
/lgtm |
github-actions
Bot
added
the
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
- Update file paths from internal/capacity to internal/saturation - Update collector references to use v2 infrastructure - Fix import paths to use internal/engines/saturation/metrics - Update API names: AnalyzeModelCapacity -> AnalyzeModelSaturation - Update API names: CalculateCapacityTargets -> CalculateSaturationTargets - Add details about v2 collector features (staleness filtering, query templates) - Update test paths to internal/saturation/analyzer_test.go - Fix terminology throughout (capacity -> saturation where appropriate) - Remove outdated note about 0.4.0 alignment Related to PR #560 (cleanup: remove collector v1)
7 tasks
ev-shindin
pushed a commit
to ev-shindin/workload-variant-autoscaler
that referenced
this pull request
Jan 14, 2026
cleanup: remove collector v1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.