chore(cleanup)!: kill vector_db references as far as possible #3864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinb
requested review from
bbrowning,
ehhuang,
franciscojavierarceo,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
ashwinb
changed the title
ashwinb
commented
Oct 20, 2025
| from llama_stack_client import Agent, AgentEventLogger, RAGDocument, LlamaStackClient | ||
|
|
||
| vector_db_id = "my_demo_vector_db" | ||
| vector_store_id = "my_demo_vector_store" |
franciscojavierarceo
approved these changes
Oct 20, 2025
|
Probably will break UI but I can fix that later as we haven't deployed it to NPM or anything so it's not a big deal |
ashwinb
commented
Oct 20, 2025
slekkala1
reviewed
Oct 20, 2025
| shields Manage safety shield services. | ||
| toolgroups Manage available tool groups. | ||
| vector_dbs Manage vector databases. | ||
| vector_stores Manage vector databases. |
There was a problem hiding this comment.
nit: Manage vector stores
ashwinb
changed the title
ashwinb
force-pushed
the
vector_db_nomo
branch
from
f622211 to
016388b
Compare
Yeah almost certainly will break the UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should not be "vector db" anywhere.