Skip to content

Conversation

@ad-astra-video
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)

Adds a test to show minimum Gateway reserve when gas spikes happen.

go-livepeer uses avgGasPrice and redeemGasL2 to calculate tx cost when gas spikes happen. The result is 0.36 ETH (3 gwei * 1,200,00 * 100) will enable Gateways to not have down time when gas spikes happen.

Specific updates (required)

  • Added a test to show 0.36 ETH will not fail to produce tickets.

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added the go Pull requests that update Go code label Sep 23, 2025
@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.67052%. Comparing base (c492248) to head (c5541b3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3748         +/-   ##
===================================================
- Coverage   31.67308%   31.67052%   -0.00256%     
===================================================
  Files            159         159                 
  Lines          38970       38970                 
===================================================
- Hits           12343       12342          -1     
- Misses         25734       25735          +1     
  Partials         893         893                 

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 586f1d6...c5541b3. Read the comment docs.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ad-astra-video
Copy link
Collaborator Author

@leszko do you think this test should be in the code base? It just demonstrates the minimum required ETH reserve during gas spikes with the avg gas cost calcs. I did it to illustrate how it works for #3746.

We did also update Gateway docs so maybe that is enough. https://docs.livepeer.org/gateways/guides/fund-gateway#deposit-gateway-funds-via-livepeer-cli

@leszko
Copy link
Contributor

leszko commented Nov 13, 2025

@leszko do you think this test should be in the code base? It just demonstrates the minimum required ETH reserve during gas spikes with the avg gas cost calcs. I did it to illustrate how it works for #3746.

We did also update Gateway docs so maybe that is enough. https://docs.livepeer.org/gateways/guides/fund-gateway#deposit-gateway-funds-via-livepeer-cli

Is there any reason for not keeping it in the codebase? If not, then I'll merge this one in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants