Skip to content

Rename connectParams -> SignalClientConnectParams (to make it exportable) #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidzhao merged 1 commit into from
Nov 15, 2024
Merged

Rename connectParams -> SignalClientConnectParams (to make it exportable) #540

davidzhao merged 1 commit into from
Nov 15, 2024

Conversation

@UladzimirTrehubenka
Copy link
Contributor

@UladzimirTrehubenka UladzimirTrehubenka commented Oct 7, 2024

Fix #534

@UladzimirTrehubenka UladzimirTrehubenka mentioned this pull request Oct 7, 2024
Closed
@CLAassistant
Copy link

CLAassistant commented Oct 7, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@davidzhao davidzhao merged commit 8a26afa into livekit:main Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not being able to use signalclient after migrate from v1 to v2

3 participants

@UladzimirTrehubenka @CLAassistant @davidzhao