Skip to content

fix: windows crashes & builds #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Apr 24, 2023
Merged

fix: windows crashes & builds #55

merged 21 commits into from
Apr 24, 2023

Conversation

theomonnom
Copy link
Member

@theomonnom theomonnom commented Apr 21, 2023 •
edited
Loading

  • Doing jobs in parallels in GHA (Divide build time by 3).
  • Now use custom webrtc builds for this repo
  • Windows crashes when receiving video is now fixed (thanks @cloudwebrtc)
    • Now reading defines from webrtc.ninja
  • Added a small create_pc test to be sure libwebrtc is working/linked correctly
  • Fix MacOS builds
  • Fixed Linux duplicated main build error (due to nasm)

Debug builds of webrtc are still not supported inside the Rust SDK (even if we're still building them). On Windows, Rust never links against libcmtd... (Pending/Draft PR). Not tested for other platforms

@theomonnom theomonnom marked this pull request as draft April 21, 2023 13:58
@theomonnom theomonnom marked this pull request as ready for review April 24, 2023 11:27
@theomonnom theomonnom changed the title fix: windows crashes & macos builds fix: windows crashes & builds Apr 24, 2023
cloudwebrtc
cloudwebrtc approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@theomonnom theomonnom merged commit 8f294dd into main Apr 24, 2023
@theomonnom theomonnom deleted the theo/fixmac branch April 24, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

@davidzhao davidzhao Awaiting requested review from davidzhao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theomonnom @cloudwebrtc