[draft] add is_end_of_turn for user transcription#1952
Open
Conversation
theomonnom
reviewed
Apr 10, 2025
| self._session.emit( | ||
| "user_input_transcribed", | ||
| UserInputTranscribedEvent(transcript=ev.transcript, is_final=True), | ||
| UserInputTranscribedEvent(transcript=ev.transcript, is_final=True, is_end_of_turn=True), |
Member
There was a problem hiding this comment.
for the realtime API, I don't think _on_input_audio_transcription_completed is a reliable signal to trigger is_end_of_turn.
Contributor
Author
There was a problem hiding this comment.
Yes, but I didn't find a better signal, actually this is the only signal for OAI realtime API? The user transcription generation is async with the conversation items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft to see how to implement the
is_end_of_turnflag for the transcription.The current implementation only helps the case when using STT with EOU model.