Add attributes inspector and explicit dispatch support#144
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
Contributor
Author
|
@MahmoudHemaid thanks for the PR - I've merged it to main and then made some improvements in here. great work this is now very nice! |
lukasIO
approved these changes
May 29, 2025
| const { localParticipant } = useLocalParticipant(); | ||
|
|
||
| // Update local attributes when props change | ||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
what's the purpose of running this effect ?
Contributor
Author
There was a problem hiding this comment.
it's a one-way sync from the parent, since the local one can have unsaved changes so doesn't directly bind to the parent attributes. not sure if its the best way, and also i don't currently have the parent actually observing attributes live either (for user, where they're editable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #142 and adds: