chore: remove unused variables in the k6 chaos fault #725
+0
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: namkyu1999 <[email protected]>
namkyu1999
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
Signed-off-by: namkyu1999 <[email protected]>
9 tasks
ispeakc0de
reviewed
Jan 15, 2025
| @@ -63,8 +63,6 @@ func Experiment(ctx context.Context, clients clients.ClientSets) { | |||
|
|
|||
| //DISPLAY THE APP INFORMATION | |||
| log.InfoWithValues("[Info]: The application information is as follows", logrus.Fields{ | |||
| "Namespace": experimentsDetails.AppNS, | |||
There was a problem hiding this comment.
We can remove //PRE-CHAOS APPLICATION STATUS CHECK and //PRE-CHAOS APPLICATION STATUS CHECK as well
ispeakc0de
reviewed
Jan 15, 2025
| @@ -125,8 +124,6 @@ func createHelperPod(ctx context.Context, experimentsDetails *experimentTypes.Ex | |||
| Args: []string{ | |||
| mountPath + "/" + experimentsDetails.ScriptSecretKey, | |||
| "-q", | |||
| "--duration", | |||
There was a problem hiding this comment.
This duration field is not required?
There was a problem hiding this comment.
yes, we can specify duration on the k6 script (fyi: Order of Precedence)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
durationenv because this value overrides script'sduration(fyi: Order of Precedence)Checklist:
breaking-changestagrequires-upgradetag