fix: Use correct field_meta for constrained union types when building field values for coverage #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bullfest
changed the title
… field values for coverage
bullfest
commented
Oct 29, 2025
|
|
||
| AFactory = ModelFactory.create_factory(A, __allow_none_optionals__=False) | ||
|
|
||
| assert AFactory.build() |
There was a problem hiding this comment.
My fix only seems to work for pydantic 2, adding a call to coverage here crashes
Suggested change
| assert AFactory.build() | |
| assert AFactory.build() | |
| assert list(AFactory.coverage()) |
(Note that this also fails on main)
|
Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the child-
FieldMetawith the matching annotation seem to pick up the correct constraints for constrained union types.Closes
Fixes #769