-
-
Notifications
You must be signed in to change notification settings - Fork 500
ci: migrate to prek from pre-commit #4496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JacobCoffee
wants to merge
8
commits into
main
Choose a base branch
from
chore/migrate-to-prek
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+44
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add header comments recommending prek as a faster alternative to pre-commit. The configuration file remains fully compatible with both tools. Closes #4492 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Update the workflow section to recommend prek as a faster alternative to pre-commit for running linting hooks. Both tools remain supported and use the same configuration file. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Update the pre-commit target to automatically use prek if installed, falling back to pre-commit otherwise. This provides faster linting for developers who have prek installed while maintaining backwards compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Remove pre-commit from linting dependencies since prek is a standalone binary that doesn't require it. Developers who prefer pre-commit can still install it via `uvx pre-commit` or `pipx install pre-commit`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Update the upgrade target to use prek autoupdate when available, falling back to uvx pre-commit autoupdate otherwise. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replace pre-commit with prek in the CI validate job for faster linting. Uses taiki-e/install-action for reliable binary installation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replace the pre-commit devcontainer feature with Rust toolchain and install prek via cargo in the postCreateCommand. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
JacobCoffee
commented
Nov 26, 2025
JacobCoffee
commented
Nov 26, 2025
JacobCoffee
commented
Nov 26, 2025
JacobCoffee
commented
Nov 26, 2025
JacobCoffee
commented
Nov 26, 2025
JacobCoffee
commented
Nov 26, 2025
Simplify prek usage by using uvx everywhere: - Update config header to show uvx prek command - Update CONTRIBUTING.rst to use uvx for both tools - Update Makefile to use uvx prek directly - Update CI to use uvx prek via astral-sh/setup-uv - Simplify devcontainer to just run uv sync 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ci
This PR involves changes to the CI/Infra
area/dependencies
This PR involves changes to the dependencies
area/docs
This PR involves changes to the documentation
pr/internal
size: small
type/docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes
Closes #4492