-
-
Notifications
You must be signed in to change notification settings - Fork 503
fix: duplicate query parameters fail validation if one of the paramaters is a list #4469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4469 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 296 296
Lines 15301 15311 +10
Branches 1715 1714 -1
=======================================
+ Hits 14970 14980 +10
Misses 189 189
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4469 |
provinzkraut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, but I think this should take into account header parameters as well. The same semantics should apply there as well
…n-sequence fields
518da05 to
ec28bb4
Compare
Cool, done now I also refactored some stuff as MultiDict, which I can imagine having a perf impact (probably positive, Multidict should be fast, but who knows, it could be negative) Is there a performance testing suite/metrics for Litestar? |
Description
Allow a single query parameter to be aliased to multiple Python parameters, even when one of the Python parameters is a list.
Previously, if a query paramater was remapped to multiple different Python paramenters by using
Parameter(query="alias")and one of the Python parameters was a list, a validation error was raised. This was inconsisent with how non-list query parameters worked.Fixes #4242