Control source registry of Lisp docker images#103
Merged
sionescu merged 7 commits intolispci:masterfrom Sep 27, 2024
Merged
Conversation
Because the cl-foundation docker image registry is no longer maintained, substitute in docker images from my personal repo on DockerHub.
Instead of making the matrix more complicated, ensure that all my images have a `latest` tag.
Previously, if building clean failed, then the workflow would abort and the log would be lost. Now we try to continue to save the build artifacts and after that fail if the build fails.
Having :force :all caused recompilation of Alexandria, emitting warnings and erroneously breaking the build. The script specifically loads warning-emitting dependencies *before* `load-system` on FiveAM.
This makes the script more compatible with the Docker image used in the GitHub Actions.
Contributor
Author
|
Looks like this is all ready to go. I removed references to ancient docker images from clfoundation and replaced them with some I have hand-built. Please do consider merging this -- I hope it will make FiveAM maintenance a lot easier. |
sionescu
approved these changes
Sep 27, 2024
Member
sionescu
left a comment
sionescu
left a comment
There was a problem hiding this comment.
Thank you very much for the work.
Contributor
Author
|
Glad to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the cl-foundation docker image registry is no longer maintained, substitute in docker images from my personal repo on DockerHub.