Increase coverage #149
Merged
Increase coverage #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Before it would just remove it.
Comment out redundant conditions in else clauses.
This reverts commit ef045fc. Will push this in a separate PR, as we froze contracts for the audit.
As contracts are frozen for the audit.
As contracts are frozen for the audit.
RickGriff
reviewed
Dec 3, 2020
|
|
||
| await web3.eth.sendTransaction({ to: defaultPool.address, from: owner, value: amount }) | ||
|
|
||
| await th.assertRevert(defaultPool.sendETH(nonPayable.address, amount, { from: owner }), 'DefaultPool: sending ETH failed') |
There was a problem hiding this comment.
Hmm does this revert because defaultPool.sendETH is only callable TroveManager though? If so, it wouldn't hit the final _require(success, ...) that we want to test here
There was a problem hiding this comment.
Good point, but no, because owner is the TroveManager here 😉 :
https://github.com/liquity/dev/pull/149/files#diff-ff756b67b4b4fded33dc971414822ef458d9dc958a1ee0bb38f11c99d6fc4daaR17
Anyway, this highlights again the importance of revert messages. While testing these PRs I restore the message check in testHelpers, but I may forget it sometimes. Hopefully we can have issue #99 fixed soon! 🤞
There was a problem hiding this comment.
Ah yes, I see. Nice.
Definitely, thanks!
RickGriff
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #74