Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange revert error message #99

Open
ricktobacco opened this issue Nov 14, 2020 · 5 comments
Open

Strange revert error message #99

ricktobacco opened this issue Nov 14, 2020 · 5 comments
Assignees
Milestone

Comments

@ricktobacco
Copy link
Contributor

The following error message happens with tests related to closeLoan, as well as mint and burn :

Transaction reverted without a reason and without a valid sourcemap provided by the compiler. Some line numbers may be off. We strongly recommend upgrading solc and always using revert reasons.

@ricktobacco ricktobacco self-assigned this Nov 14, 2020
@RickGriff
Copy link
Collaborator

RickGriff commented Nov 15, 2020

I am now getting strange revert error messages for all CDPManager tests in AccessControlTest.js after updating my editor compiler settings. Some revert without a reason, others with this:

Transaction reverted: function was called with incorrect parameters

The txs succeed when the access control is disabled, i.e. if the _require(...) is commented out. Otherwise, the txs revert (as they should), but with the wrong revert message.

It does seem like a compiler-related issue.

As a temporary fix I commented out the revert message assertions in bd7677c, so the CDPManager access control tests just check the tx receipt status.

@ricktobacco
Copy link
Contributor Author

ricktobacco commented Nov 18, 2020

Now I'm strangely getting it on the protect_lusd_transfer branch @bingen
Screen Shot 2020-11-18 at 7 18 41 AM
Screen Shot 2020-11-18 at 7 19 33 AM

@bingen
Copy link
Collaborator

bingen commented Nov 19, 2020

I’ve hit this one too. Very weird, with test “registerFrontEnd(): reverts if the kickback rate >1”.

  • I thought it may be because buidler uses solc: 0.6.8, so I tried upgrading to hardhat, but no luck.
  • I also tried downgrade contracts to 0.6.8, no luck.
  • I tried with Node 14 instead of 12, no luck.

Just reporting here so we can discard possible origins.

@bingen
Copy link
Collaborator

bingen commented Nov 19, 2020

I tried with waffle too, it didn’t work either. 😢

@bingen
Copy link
Collaborator

bingen commented Nov 25, 2020

Reference: NomicFoundation/hardhat#1046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants