Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new immich-server config sample. #721

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

DougEdey
Copy link
Contributor

@DougEdey DougEdey commented Dec 6, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description

Immich's official docker-compose.yml uses the main immich service as immich_server, as per discussion in #713 the feedback was to create a new config instead of updating the original.

That PR also used immich-server, so I'm not sure in @NLZ has a different docker setup to mine that changes the container_name directive to use - instead of _, but mine definitely creates immich_server:

❯ docker ps --format "{{.Names}}" | grep immich
immich_server
immich_postgres
immich_machine_learning
immich_redis

I updated the date on the original config to draw attention to this.

Also, I found a small typo in the CONTRIBUTING.md

Benefits of this PR and context

This requires less setup for users with immich, which means less chance of mistakes.

How Has This Been Tested?

I'm running this config locally in my SWAG instance without issues.

Source / References

The original official docker-compose never had immich as the service name, I suspect that the original SWAG config came from a community based template: https://github.com/immich-app/immich/blame/7cc7fc0a0c974e907702e0887b48312d3dd0a2b4/server/docker-compose.yml

I couldn't find any details in the wiki history either for the old name.

Immich updated their official docker-compose.yml and renamed the immich service to immich-server, as per discussion in linuxserver#713 the feedback was to create a new config.

I updated the date on the original config to draw attention to this.
@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@DougEdey
Copy link
Contributor Author

DougEdey commented Jan 7, 2025

Should be still valid to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants