-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add search via select2 for application dropdown #1155
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@gfomichev Thanks for reviewing this PR. Any idea on why it's not merging/what else is required? |
sorry, not the slightest idea |
@gfomichev who's in charge of approving and merging this kind of PRs? Who's the maintainer of this project? |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
@0x1026 @gfomichev what else is needed for this PR to be merged? As I can see, there are 2 approvals already. Who else has "Write access" to approve it? |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Well, the members which have permissions ignore this pr. Nice maintainers! |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
@KodeStar Would you mind chiming in here? |
I've approved the changes as select2 is already included, I'm not sure it's really necessary (start typing the name of an app will take you to it anyway, or typing the name in the application name and selecting an option will also select the app) but if some people find it helpful I'm ok with it. |
I found searching the large list of dropdown apps to be difficult. This PR adds search to the dropdown via the provided select2 package (see screenshots).