Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search via select2 for application dropdown #1155

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

TheDen
Copy link
Contributor

@TheDen TheDen commented Apr 29, 2023

I found searching the large list of dropdown apps to be difficult. This PR adds search to the dropdown via the provided select2 package (see screenshots).

image

image

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

@gfomichev gfomichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@TheDen
Copy link
Contributor Author

TheDen commented Aug 2, 2023

@gfomichev Thanks for reviewing this PR. Any idea on why it's not merging/what else is required?

@gfomichev
Copy link

@gfomichev Thanks for reviewing this PR. Any idea on why it's not merging/what else is required?

sorry, not the slightest idea

@amasolini
Copy link

@gfomichev who's in charge of approving and merging this kind of PRs? Who's the maintainer of this project?

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@amasolini
Copy link

@0x1026 @gfomichev what else is needed for this PR to be merged? As I can see, there are 2 approvals already. Who else has "Write access" to approve it?

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@0x1026
Copy link

0x1026 commented Nov 29, 2023

Well, the members which have permissions ignore this pr. Nice maintainers!

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@mvdkleijn
Copy link

@KodeStar Would you mind chiming in here?

@KodeStar
Copy link
Member

I've approved the changes as select2 is already included, I'm not sure it's really necessary (start typing the name of an app will take you to it anyway, or typing the name in the application name and selecting an option will also select the app) but if some people find it helpful I'm ok with it.

@KodeStar KodeStar merged commit ecb668a into linuxserver:2.x Feb 12, 2024
5 checks passed
@TheDen TheDen deleted the add-search-application-item branch May 24, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants