refactor: split CLI setup and pass 2 orchestration#61
Merged
Conversation
- Move run validation, encoder checks, and runtime config assembly out of
`main.go`
- Extract pass 2 orchestration and preview cadence handling into helpers
- Trim stale comments and keep config constants and tests aligned
Signed-off-by: Martin Wimpress <code@wimpress.io>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 10 files
Confidence score: 3/5
- In
cmd/jive-visualiser/pipeline.go, quitting viatea.Quitcan still leave the process blocked waiting onanalysisErrCh, so the app may look hung even after the TUI exits and users may assume quit is broken — add cancellation wiring for the background pass (or make the post-quit channel wait non-blocking) before merging.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- Mark the progress model as interrupted when the user quits - Skip final summary output when exit came from the live view - Add tests for quit handling and completed view behaviour Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
0 issues found across 3 files (changes from recent commits).
Requires human review: Massive refactor extracting CLI setup, pass 2 orchestration, and preview cadence handling into new files. 1105 lines changed with 3 new files. Restructures core execution flow and changes preview payload function signature. High risk of introduced bugs despite review finding no issues.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main.go