Skip to content

Conversation

@justforlxz
Copy link
Member

@justforlxz justforlxz commented Jan 5, 2026

Automatic detection may have issues on some machines; setting it to 1
will use the best vision.

PMS: BUG-346495
Log:

Summary by Sourcery

Bug Fixes:

  • Force the compositing user_type default to 1 to avoid issues with automatic detection on some systems.

Automatic detection may have issues on some machines; setting it to 1
will use the best vision.

PMS: BUG-346495
Log:
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the KWin compositing configuration to set the user_type default value explicitly to 1 to avoid unreliable automatic detection on some machines.

File-Level Changes

Change Details Files
Set the compositing user_type default to 1 instead of relying on automatic detection.
  • Update the user_type configuration entry to default to 1
  • Ensure the value corresponds to the profile that uses the best vision/graphics path
  • Retain all other compositing configuration options unchanged
configures/org.kde.kwin.compositing.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@justforlxz justforlxz requested a review from wineee January 5, 2026 07:59
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

release 6.0.6

Log:
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

TAG Bot

TAG: 6.0.6
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

deepin pr auto review

我来帮你分析这个git diff的内容:

  1. 语法逻辑:
  • 修改的内容是JSON配置文件,语法格式正确
  • changelog的格式符合Debian包管理规范
  1. 代码质量:
  • 修改简单明确,只涉及配置值的更改
  • 在changelog中有清晰的变更记录
  • 变更内容与描述一致,将user_type的默认值从0改为1
  1. 性能影响:
  • 这是一个配置值的修改,不会对运行时性能产生影响
  • 修改仅涉及默认值的设置,不会增加系统开销
  1. 安全性:
  • 修改仅涉及配置参数,不存在安全风险
  • 变更内容是简单的数值调整,不会引入安全漏洞

改进建议:

  1. 文档完善:
  • 建议在changelog中补充说明为什么需要将默认值改为1
  • 可以考虑在代码注释中说明不同数值(0和1)分别代表什么效果
  1. 版本控制:
  • changelog中的日期(2026年1月5日)似乎有误,建议修正为当前日期
  • 版本号从6.0.5升级到6.0.6符合语义化版本规范
  1. 变更影响:
  • 建议评估这个默认值变更对现有用户的影响
  • 考虑是否需要提供迁移指南或向后兼容方案
  1. 测试建议:
  • 应该验证新的默认值在各种场景下的表现
  • 建议添加相关的单元测试或集成测试
  1. 配置说明:
  • 可以考虑在配置文件中添加注释,说明user_type不同值的含义
  • 建议提供配置文档,帮助用户理解各个选项的作用

总的来说,这是一个简单的配置值修改,但从软件工程的角度来看,还可以在文档、测试和向后兼容性方面做一些改进。

@deepin-ci-robot
Copy link

@justforlxz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
github-trigger-obs-ci 3bd5817 link true /test github-trigger-obs-ci

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz, wineee

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justforlxz justforlxz merged commit a149d8f into linuxdeepin:master Jan 5, 2026
18 of 19 checks passed
@Zeno-sole
Copy link

/integrate

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#3603
PrNumber: 3603
PrBranch: auto-integration-20711304355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants