Skip to content

feat: update transifex file - #378

Closed
JWWTSL wants to merge 1 commit into
linuxdeepin:masterfrom
JWWTSL:master
Closed

JWWTSL wants to merge 1 commit into
linuxdeepin:masterfrom
JWWTSL:master

Conversation

@JWWTSL

@JWWTSL JWWTSL commented Jun 19, 2025

Copy link
Copy Markdown

log: Updating transifex platform related configuration files

Summary by Sourcery

CI:

  • Introduce .tx/transifex.yaml to define filters for DDE-KWin and desktop translation files and set PR branch naming conventions

log: Updating transifex platform related configuration files
@sourcery-ai

sourcery-ai Bot commented Jun 19, 2025

Copy link
Copy Markdown

Reviewer's Guide

Introduce Transifex platform configuration by adding a new .tx/transifex.yaml file with license headers, translation filters, and branch naming settings.

Flow diagram for Transifex translation file processing

flowchart TD
  A[Source Translation File: translations/dde-kwin.ts]
  B[Source Translation File: translations/desktop/desktop.ts]
  C[Transifex Platform]
  D[Translation Output: translations/dde-kwin_<lang>.ts]
  E[Translation Output: translations/desktop/desktop_<lang>.ts]

  A --> C
  B --> C
  C --> D
  C --> E
Loading

File-Level Changes

Change Details Files
Introduce Transifex configuration file
  • Add SPDX license header
  • Define translation file filters for core and desktop modules
  • Configure PR branch naming pattern for Transifex updates
.tx/transifex.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JWWTSL - I've reviewed your changes - here's some feedback:

  • Double-check that the <br_unique_id> placeholder in pr_branch_name is properly substituted by your CI—otherwise branch names may include literal angle brackets.
  • Verify that the translation_files_expression patterns match your actual TS filenames to avoid missing any translation resources.
  • As you add more modules, consider grouping or commenting filter entries by component to keep this file maintainable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Double-check that the `<br_unique_id>` placeholder in `pr_branch_name` is properly substituted by your CI—otherwise branch names may include literal angle brackets.
- Verify that the `translation_files_expression` patterns match your actual TS filenames to avoid missing any translation resources.
- As you add more modules, consider grouping or commenting filter entries by component to keep this file maintainable.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JWWTSL

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • .tx/transifex.yaml 文件中缺少对 br_unique_id 的定义,这可能会导致在创建分支名称时出现问题。
  • 文件末尾的换行符 \ No newline at end of file 可能会导致在跨平台文件传输时出现问题。

是否建议立即修改:

@wineee

wineee commented Jul 1, 2025

Copy link
Copy Markdown
Member

dde-kwin don't has anything need translation

@wineee wineee closed this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants