Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/u boot env offset #7

Closed
wants to merge 2 commits into from

Conversation

gderoire
Copy link

Hi,

This is a small fix of mtdparts u-boot parameters that don't match CONFIG_ENV_OFFSET value since the define has been updated in commit 4744f87.

I have seen the issue when I have updated a at91sam9g45-ekes board. sam-ba script still point on old address for u-boot-env. A sam-ba script fix is also submitted on meta-atmel.

I was only able to test it on at91sam9g45ekes board.

Regards

gderoire added 2 commits July 23, 2018 15:16
It seems not all configs have been updated in the commit to match sama5
address (4744f87)
…91sam9261ek

It seems sam9261ek was skipped in the commit to match sama5
address (4744f87)
@ehristev ehristev self-assigned this Jul 30, 2018
@ehristev
Copy link

Hello,

Can you check if this is consistent with mainline u-boot ?
In latest version of u-boot ,the BOOTARGS have been moved to the defconfig files.
It should be fixed in those defconfigs, to have the proper mtdparts variable.

Thanks

@gderoire
Copy link
Author

Thanks to raise that point. I will have a look to mainline. I'll keep You updated.

@ehristev
Copy link

ehristev commented Sep 5, 2018

Need to check if
1: the NAND flash has enough capacity for these offsets
2: the SAM-BA scripts will write to the same offsets
3: the board works and boots with these offsets.
4: mainline u-boot has the wrong offsets as well, and if the patch is better to go upstream rather than this old 2017.03 branch which will be outdated in favor of mainline u-boot.
5: update your signed-off-by tag in your commit.

Please check the above and reopen the request with proper changes.

@ehristev ehristev closed this Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants