Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redhat: Add missing rdma-load-modules systemd scriptlets #1558

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

Kamalheib
Copy link
Contributor

Add the missing systemd restart bits for the rdma-load-modules.

Add the missing systemd restart bits for the rdma-load-modules.

Signed-off-by: Kamal Heib <[email protected]>
@rleon rleon merged commit dfd8417 into linux-rdma:master Feb 16, 2025
14 checks passed
@rleon
Copy link
Member

rleon commented Feb 16, 2025

@nmorey do you need anything like this in SuSE?

@nmorey
Copy link
Contributor

nmorey commented Feb 16, 2025

@rleon Need? No. It does work fine like that unless I'm missing something.
As the rdma-load-modules service isn't really a usual system service but just a trickery to load kmod, it seems to be working all right without the usual heavy systemd/RPm macro.
But we can probably have something similar (we do use %service_ macros and not %systemd directly). Not sure if it's worth the hassle. I'll check with my systemd colleagues

Thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants