test: Add library dependency for dlsym #919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix build failure for test [27/79] Linking target test/ioctl/libmock-ioctl.so FAILED: test/ioctl/libmock-ioctl.so cc -o test/ioctl/libmock-ioctl.so test/ioctl/libmock-ioctl.so.p/mock.c.o test/ioctl/libmock-ioctl.so.p/util.c.o -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,--start-group -Wl,-soname,libmock-ioctl.so -Wl,--end-group test/ioctl/libmock-ioctl.so.p/mock.c.o: In function `ioctl': /root/Desktop/repo/libnvme_upstream/.build/../test/ioctl/mock.c:154: undefined reference to `dlsym' Signed-off-by: Steven Seungcheol Lee <[email protected]>
|
Ooops, though have to look into why the CI build fails horrible. |
|
Which version of meson are you using? IIRC some libraries are added to the dependency list automatically and the dl lib might one of them. That might be the reason why it was failing in CI and on my machine. |
|
I've merged my fix from #923 which works around the problem when dl is not available. Thanks for the report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build failure for test
[27/79] Linking target test/ioctl/libmock-ioctl.so FAILED: test/ioctl/libmock-ioctl.so
cc -o test/ioctl/libmock-ioctl.so test/ioctl/libmock-ioctl.so.p/mock.c.o test/ioctl/libmock-ioctl.so.p/util.c.o -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,--start-group -Wl,-soname,libmock-ioctl.so -Wl,--end-group test/ioctl/libmock-ioctl.so.p/mock.c.o: In function
ioctl': /root/Desktop/repo/libnvme_upstream/.build/../test/ioctl/mock.c:154: undefined reference todlsym'