types: Update id-ctrl field based on NVMe 2.1 spec #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
reviewed
Dec 2, 2024
|
looks good, just add the mask/shift things and also the missing bit field definition, so that all is consistent. thanks |
|
Updated based on review :) |
Boot Partition Capabilities (BPCAP) NVM Subsystem Shutdown Latency (NSSL) Power Loss Signaling Information (PLSI) Controller Reachability Capabilities (CRCAP) Key Per I/O Capabilities (KPIOC) Maximum Processing Time for Firmware Activation Without Reset (MPTFAWR) Command Quiesce Time (CQT) Recommended Host-Initiated Refresh Interval (RHIRI) Host-Initiated Refresh Time (HIRT) Add missing explaination for NVME_TELEMETRY_DA_CTRL_DETERMINE Signed-off-by: Steven Seungcheol Lee <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boot Partition Capabilities (BPCAP)
NVM Subsystem Shutdown Latency (NSSL)
Power Loss Signaling Information (PLSI)
Controller Reachability Capabilities (CRCAP)
Key Per I/O Capabilities (KPIOC)
Maximum Processing Time for Firmware Activation Without Reset (MPTFAWR)