test: use diff to compare sysfs output #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I added this code I decided against using an external tool, so that we don't have a build dependency on the tool. Maybe add a check to meson an if available use it? |
FYI, I have already wired Lines 64 to 68 in 553c15e |
|
Yes, and this case this the nbft test will not be executed when diff is missing. So this should handled in the same way. |
calebsander
force-pushed
the
feature/test-sysfs-diff
branch
from
29f1f07 to
3e4ef43
Compare
The sysfs tests are currently hand-rolling file comparison. Use diff -u instead to get a rich comparison if the comparison fails. Create a single shell script that combines extracting the sysfs files, invoking the test program to generate the tree output, and diffing the result against the expected output. This reduces the C and Meson code needed for the test. Signed-off-by: Caleb Sander Mateos <[email protected]>
calebsander
force-pushed
the
feature/test-sysfs-diff
branch
from
3e4ef43 to
dd4a057
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sysfs tests are currently hand-rolling file comparison. Use
diff -uinstead to get a rich comparison if the comparison fails. This also simplifies the test code significantly.