Add sysfs tests #775
Merged
Add sysfs tests #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is available since the 1.0 release. Export it. Signed-off-by: Daniel Wagner <[email protected]>
Allow the user to select the output filedescriptor instead always dumping it to stdout. This allows to write the output to a file. Signed-off-by: Daniel Wagner <[email protected]>
In order to be able to test the topology scan code, make the lookup paths flexible. Check if the LIBNVME_SYSFS_PATH environment variable is set and if so use this as base path. We could also introduce a setter for this, but this is really a debugging interface and thus I don't really want it to be visible in the public API. Signed-off-by: Daniel Wagner <[email protected]>
In order to be able to test the topology scan code, allow hostnqn and hostid to be controlled via an environment variable. This is just for testing purposes, thus don't mention it. Signed-off-by: Daniel Wagner <[email protected]>
igaw
force-pushed
the
add-sysfs-tests
branch
2 times, most recently
from
6e89367 to
89afed9
Compare
The library is able to scan the topology from a simple copy of sysfs. There is no need to do any IOCTL, thus we can start test to tree code. This provides just the basic building blocks. Signed-off-by: Daniel Wagner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the limitation gone that we have to do IOCTLs to parse the topology, let's add infrastructure to tests this code in the CI build.
Fixes: #759