Skip to content

Commit

Permalink
build: Add token for coverage test
Browse files Browse the repository at this point in the history
The code coverage action is silently failing partly because the required
Codecov token is missing.
Reading the token from the GitHub secrets.

The missing gpg package must be fixed in
https://github.com/linux-nvme/ci-containers.

Furthermore, fail the coverage workflow if the codecov-action errors out.

Signed-off-by: Dennis Maisenbacher <[email protected]>
  • Loading branch information
MaisenbacherD authored and igaw committed Oct 31, 2024
1 parent 81073a1 commit 89ea2b7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ jobs:
scripts/build.sh coverage
- uses: codecov/codecov-action@v4
with:
fail_ci_if_error: false
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true

0 comments on commit 89ea2b7

Please sign in to comment.