change: [DI-24111] - Updated hovering color for dashboard icons #11883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhagra-akamai
requested review from
bnussman-akamai and
coliu-akamai
and removed request for
a team
venkymano-akamai
approved these changes
Mar 19, 2025
bnussman-akamai
requested changes
Mar 19, 2025
There was a problem hiding this comment.
Our <IconButton />'s default styles are to turn blue on hover. We shouldn't need to apply custom styles to accomplish this.
Also, the Icons are completely broken in dark mode
Screen.Recording.2025-03-19.at.11.42.05.AM.mov
I recommend the following
- Open up
zoomin.svg,zoomout.svg,refresh.svg. Change allfills andstrokes to usecurrentColorrather than their hardcoded colors - Remove styled icons and one-off styles completely
These changes will make the code much cleaner, simple, and has the added benefits of pulling styles from our theme. The more one-off styles we have, the harder it will be to make a cohesive application with a good user experience.
packages/manager/src/features/CloudPulse/Overview/GlobalFilters.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Widget/components/Zoomer.tsx
Outdated
Show resolved
Hide resolved
|
thanks of code cleanup suggestions @bnussman-akamai I've modified the changes accordingly. I've added color prop in icons button as default button color is light but as per mockups it is a bit darker. |
Cloud Manager UI test results🎉 539 passing tests on test run #7 ↗︎
|
bnussman-akamai
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Added blue color to icon on hover in dashboards
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅