Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-9517] - Update LKE-E flows to account for LDE being disabled at LA launch #11880

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Mar 18, 2025

Description 📝

This is a late add that came out of reviews ahead of LKE-E's LA release.

The ask is to expose the fact that LDE is not enabled for the cluster during the cluster creation time. It is not sufficient to show it in the UI after the cluster is created or to just have it in tech docs.

Reasons LDE may not be enabled:

  • LDE is turned off by LKE-E (this is expected to be the case for LA launch with a global flag on the backend; we don't have access to this flag)
  • DC in which the LKE-E cluster is created does not support LDE (this is already being handled today)

This changes will be reversed in coming weeks when LDE becomes available for LKE-E. Given potential merge conflicts with the last LDE changes in staging and the fact that this is not long-lasting, I did not go through the hassle of adding test coverage.

Changes 🔄

  • Update copy in "Add Node Pools" section of the LKE Create page to explicitly mention that LKE-E node pools are not encrypted at rest
  • Also update that same copy to take out an incorrect limit that's not applicable for LKE-E
  • Hide the incorrect tooltip that would display for regions with LDE enabled, even if it wasn't possible for an LKE-E cluster to enable LDE

Target release date 🗓️

3/25

Preview 📷

Before After
Screenshot 2025-03-18 at 12 39 38 PM Screenshot 2025-03-18 at 12 39 12 PM
Screenshot 2025-03-18 at 12 42 43 PM Screenshot 2025-03-18 at 12 39 51 PM

NOTE: The expectation is that by LKE-E LA launch, nodes in node pools will have disk encryption disabled too. This doesn't seem to be the case yet on the backend today. (See LKE-6592.)

How to test 🧪

Prerequisites

(How to setup test environment)

  • Have LKE-E feature flag on and have the LKE-E customer tag on your account (see project tracker)
  • If your account can no longer create an LKE-E cluster due to recent backend pre-prod changes, use Hana's prod test account listed in our password manager.

Reproduction steps

(How to reproduce the issue, if applicable)

  • Create an LKE-E cluster. Observe there is no mention of LDE status on the create flow.
  • Go to the cluster details page and observe the node pool encryption status. There is an incorrect tooltip suggesting that LDE can be enabled.
  • Go to the Linode details page of any node in the node pool and observe the node pool encryption status. There is an incorrect tooltip suggesting that LDE can be enabled.

Verification steps

(How to verify changes)

  • Create an LKE-E cluster. Observe there is a mention of LDE status on the create flow in the node pools section.
  • Go to the cluster details page and observe the node pool encryption status. Observer there is NOT a tooltip suggesting that LDE can be enabled.
  • Go to the Linode details page of any node in the node pool and observe the node pool encryption status. Observe there is NOT is a tooltip suggesting that LDE can be enabled.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mjac0bs mjac0bs self-assigned this Mar 18, 2025
@@ -1,5 +1,11 @@
export const ADD_NODE_POOLS_DESCRIPTION =
'Add groups of Linodes to your cluster. You can have a maximum of 100 Linodes per node pool and a maximum of 250 Linodes per cluster.';

export const ADD_NODE_POOLS_ENTERPRISE_DESCRIPTION =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an unrelated change, but something I caught from the mocks. Enterprise clusters don't have the 250 maximum.

@@ -270,8 +270,17 @@ export const NodeTable = React.memo((props: Props) => {
</Typography>
<StyledVerticalDivider />
<EncryptedStatus
/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwiley-akamai Hopefully this explains the situation well enough here and in the below file. 😅

@mjac0bs mjac0bs marked this pull request as ready for review March 18, 2025 20:22
@mjac0bs mjac0bs requested a review from a team as a code owner March 18, 2025 20:22
@mjac0bs mjac0bs requested review from carrillo-erik, hasyed-akamai, dwiley-akamai and hana-akamai and removed request for a team March 18, 2025 20:22
@mjac0bs mjac0bs force-pushed the M3-9517-lde-disabled-for-lke-e-2 branch from ba4a82e to 23d7961 Compare March 19, 2025 14:35
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 539 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing539 Passing3 Skipped103m 54s

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • LKE Create page copy, incl. for LKE-E ✅

  • No tooltip for LKE-E Node Pool encryption statuses ✅

  • Linode Details page of an LKE Linode --> no encryption status tooltip re: enabling LDE ✅

    • however, if the node pool has a "Not Encrypted" status and I go to the Linode Details page of any of the pool's linodes, the linode has an "Encrypted" status -- but this is an API/back-end bug that has been ticketed, right?

@mjac0bs
Copy link
Contributor Author

mjac0bs commented Mar 19, 2025

  • however, if the node pool has a "Not Encrypted" status and I go to the Linode Details page of any of the pool's linodes, the linode has an "Encrypted" status -- but this is an API/back-end bug that has been ticketed, right?

Yes. I confirmed with Medhat that the expected behavior is that that will also be disk_enryption: disabled returned from the API by the time LKE-E launches. This one looks like it's out of our hands and in LKE-6592.

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Mar 19, 2025
@mjac0bs mjac0bs merged commit d4f8324 into linode:develop Mar 19, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! LKE-Enterprise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants