-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-9517] - Update LKE-E flows to account for LDE being disabled at LA launch #11880
upcoming: [M3-9517] - Update LKE-E flows to account for LDE being disabled at LA launch #11880
Conversation
@@ -1,5 +1,11 @@ | |||
export const ADD_NODE_POOLS_DESCRIPTION = | |||
'Add groups of Linodes to your cluster. You can have a maximum of 100 Linodes per node pool and a maximum of 250 Linodes per cluster.'; | |||
|
|||
export const ADD_NODE_POOLS_ENTERPRISE_DESCRIPTION = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an unrelated change, but something I caught from the mocks. Enterprise clusters don't have the 250 maximum.
@@ -270,8 +270,17 @@ export const NodeTable = React.memo((props: Props) => { | |||
</Typography> | |||
<StyledVerticalDivider /> | |||
<EncryptedStatus | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dwiley-akamai Hopefully this explains the situation well enough here and in the below file. 😅
ba4a82e
to
23d7961
Compare
Cloud Manager UI test results🎉 539 passing tests on test run #3 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
LKE Create page copy, incl. for LKE-E ✅
-
No tooltip for LKE-E Node Pool encryption statuses ✅
-
Linode Details page of an LKE Linode --> no encryption status tooltip re: enabling LDE ✅
- however, if the node pool has a "Not Encrypted" status and I go to the Linode Details page of any of the pool's linodes, the linode has an "Encrypted" status -- but this is an API/back-end bug that has been ticketed, right?
Yes. I confirmed with Medhat that the expected behavior is that that will also be |
Description 📝
This is a late add that came out of reviews ahead of LKE-E's LA release.
The ask is to expose the fact that LDE is not enabled for the cluster during the cluster creation time. It is not sufficient to show it in the UI after the cluster is created or to just have it in tech docs.
Reasons LDE may not be enabled:
This changes will be reversed in coming weeks when LDE becomes available for LKE-E. Given potential merge conflicts with the last LDE changes in staging and the fact that this is not long-lasting, I did not go through the hassle of adding test coverage.
Changes 🔄
Target release date 🗓️
3/25
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅