upcoming: [M3-9096] - Add factories and mocks for new API /v4/linode/interfaces endpoints
#11875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
commented
Mar 18, 2025
Comment on lines
+265
to
+269
| payload.interfaces && | ||
| payload.interfaces.some( | ||
| (iface: CreateLinodeInterfacePayload) => iface.vpc | ||
| ) | ||
| ) { |
There was a problem hiding this comment.
...hopefully this part just works, but I will make tweaks to it as needed when I begin reviewing #11847
There was a problem hiding this comment.
(ok now it works 😆)
(btw I've been testing VPC Linode interfaces on this branch, which is essentially these changes added onto the changes in #11847)
coliu-akamai
requested review from
hana-akamai and
abailly-akamai
and removed request for
a team
4 tasks
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
|
Coverage Report: ✅ |
coliu-akamai
added
Add'tl Approval Needed
coliu-akamai
added
Approved
This was referenced Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
/v4/linode/interfacesendpointsChanges 🔄
How to test 🧪
Some endpoints are currently not reachable, will be more reachable as UI continues to be built out
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅