Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-9539] - Quotas Tab Beta Chip #11872

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Mar 18, 2025

Description 📝

Small PR to add a Beta Chip to the /account "Quota" tab.

  1. We still had a <BetaChip /> in manager/src/components/ after migrating it to @linode/ui
  2. The chip color prop was also broken (default/primary were doing the same thing) so I added a secondary prop instead and if no color is passed it'll default to primary. No change for existing instances since they were all already inheriting the primary styles.

Changes 🔄

  • Delete old instance of <BetaChip /> in manager/src/components/
  • Fix <BetaChip > color prop
    • keep primary as default (existing instances)
    • add secondary style from UX guidance
  • Add new chip to the /account "Quota" tab
  • Update tests

Preview 📷

Light Mode Dark Mode
Account Quotas localhost 3000 Account Quotas (1)

How to test 🧪

Verification steps

  • Navigate to /account and confirm new chip
  • Confirm no regression with existing instances of beta chip (Primary Nav, Database Create)
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai marked this pull request as ready for review March 18, 2025 17:27
@abailly-akamai abailly-akamai requested review from a team as code owners March 18, 2025 17:27
@abailly-akamai abailly-akamai requested review from jdamore-linode, mjac0bs and harsh-akamai and removed request for a team March 18, 2025 17:27
Copy link

Coverage Report:
Base Coverage: 79.96%
Current Coverage: 79.93%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing538 Passing3 Skipped112m 42s

Details

Failing Tests
SpecTest
search-volumes.spec.tsSearch Volumes » creates two volumes and make sure they show up in the table and are searchable

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/volumes/search-volumes.spec.ts"

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigate to /account and confirm new chip

👋🏼 new chip

Screenshot 2025-03-19 at 12 27 08 PM

Confirm no regression with existing instances of beta chip (Primary Nav, Database Create)

These look good. What was UX's guidance for when to use the secondary color vs. primary?

(Asking because I'm wondering whether ApplicationPlatform for LKE should use the secondary color at some point. Currently, it doesn't even use a BetaChip; it uses a Chip for which the label is "BETA". That works for now while APL is disabled for LKE-E, but making a ticket [M3-9608] to switch this over to a BetaChip in the future while I'm here...)

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add'tl Approval Needed Waiting on another approval! Limits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants