-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-9539] - Quotas Tab Beta Chip #11872
base: develop
Are you sure you want to change the base?
Conversation
Coverage Report: ❌ |
Cloud Manager UI test results🔺 1 failing test on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/volumes/search-volumes.spec.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Navigate to /account and confirm new chip
👋🏼 new chip
Confirm no regression with existing instances of beta chip (Primary Nav, Database Create)
These look good. What was UX's guidance for when to use the secondary color vs. primary?
(Asking because I'm wondering whether ApplicationPlatform for LKE should use the secondary color at some point. Currently, it doesn't even use a BetaChip; it uses a Chip for which the label is "BETA". That works for now while APL is disabled for LKE-E, but making a ticket [M3-9608] to switch this over to a BetaChip in the future while I'm here...)
Description 📝
Small PR to add a Beta Chip to the /account "Quota" tab.
<BetaChip />
inmanager/src/components/
after migrating it to@linode/ui
color
prop was also broken (default/primary were doing the same thing) so I added a secondary prop instead and if no color is passed it'll default to primary. No change for existing instances since they were all already inheriting the primary styles.Changes 🔄
<BetaChip />
inmanager/src/components/
<BetaChip >
color
propPreview 📷
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅