-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-9531] - Nodebalancer routing (Tanstack) #11858
Conversation
}; | ||
|
||
return <NodeBalancerConfigurations {...props} {...matchProps} />; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dealing with Class Components is a bit trickier, and the cleanest way is to wrap the class component in a functional one and pass the params as props
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @abailly-akamai with this clean migration. The route organization looks very maintainable. Confirming all verifications as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Tab navigation
⚠️
Did we lose some keyboard accessibility with transition to Tanstack Router? I was unable to switch tabs using the directional arrows on my keyboard as I'm able to do in prod.
Video
Screen.Recording.2025-03-18.at.4.51.53.PM.mov
(focus changes are from me hitting the Tab
key, the rest of the time I was pressing arrows)
- Create flow ✅
- Delete flow
⚠️
It doesn't seem that we'd want the breadcrumb change in the background:
Prod | This Branch |
---|---|
![]() |
![]() |
- Unassign Firewall flow ✅
- Clicking on Ports in the NB Summary sidebar ✅
- Navigate to Firewall > Detail and confirm add firewall and unassigmnent still works ✅
- Navigate to Linode > Detail > Networking and confirm add firewall and unassigmnent still works ✅
@dwiley-akamai fixed the breadcrumb in acce170 Great catch on the tabs 👀 - it's still using reach-tabs but somehow it indeed messed up the accessibility with navigation I will create a separate ticket (high priority) in order not to extend the scope of this PR as I also will add a component test to avoid future regressions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review ✅
Verified breadcrumb fix ✅
packages/manager/src/features/Firewalls/FirewallDetail/Devices/RemoveDeviceDialog.tsx
Outdated
Show resolved
Hide resolved
Cloud Manager UI test results🎉 539 passing tests on test run #14 ↗︎
|
Description 📝
This PR contributes to the refactor of Cloud Manager Routing. It implements the Tanstack API for the
Nodebalancers
feature.Changes 🔄
Preview 📷
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅