-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-9519] - Allow LKE-E IP ACL addresses to be optional with an explicit acknowledgement #11856
upcoming: [M3-9519] - Allow LKE-E IP ACL addresses to be optional with an explicit acknowledgement #11856
Conversation
5558ac3
to
e0fe8ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/manager/src/features/Kubernetes/CreateCluster/ControlPlaneACLPane.tsx
Outdated
Show resolved
Hide resolved
Cloud Manager UI test results🔺 2 failing tests on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts,cypress/e2e/core/firewalls/delete-firewall.spec.ts" |
@@ -59,8 +64,8 @@ export const ControlPlaneACLPane = (props: ControlPlaneACLProps) => { | |||
)} | |||
<Typography mb={1} sx={{ width: '85%' }}> | |||
{isEnterpriseCluster | |||
? CREATE_CLUSTER_STANDARD_TIER_ACL_COPY | |||
: CREATE_CLUSTER_ENTERPRISE_TIER_ACL_COPY} | |||
? CREATE_CLUSTER_ENTERPRISE_TIER_ACL_COPY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of placing the tier name at the beginning of these constants to make them more distinguishable.
For example:
CREATE_CLUSTER_ENTERPRISE_TIER_ACL_COPY --> ENTERPRISE_TIER_CREATE_CLUSTER_ACL_COPY
CREATE_CLUSTER_STANDARD_TIER_ACL_COPY --> STANDARD_TIER_CREATE_CLUSTER_ACL_COPY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. I'm going to merge as is so this doesn't hold up a release branch cut, but we'll keep this in mind when we do some refactoring with the RHF PR that will have some clean up to do.
Description 📝
Currently, the ACL section for LKE-E is enabled by default. Currently, this setting cannot be disabled and requires the user to enter at least 1 IP Address to proceed with cluster creation. In general, we do want to encourage that an ACL has an IP Address to avoid user error preventing an inability to access the cluster control plane.
However, there may be workflows where a customer does not want to specify an IP address upon creation and would prefer to add one later, which is acceptable as long as they understand that their cluster will not be accessible.
This PR will introduce an acknowledgement checkbox to confirm they explicitly intend to enable ACL without IP addresses.
Changes 🔄
Target release date 🗓️
3/25
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
lke-update.spec.ts
andlke-create.spec.ts
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅