Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-9511] - VPC IPv6 - Update endpoints and types for VPC Entity #11852

Conversation

hana-akamai
Copy link
Contributor

@hana-akamai hana-akamai commented Mar 14, 2025

Description 📝

Update endpoints and types for VPC Entity

Changes 🔄

  • Add optional ipv6 property to VPC and CreateVPCPayload interface
  • Add optional ipv6 validation to createVPCSchema

Verification steps

(How to verify changes)

  • Cross-reference VPC IPv6 API spec (linked in parent ticket) and updated types for
    POST /v4/vpcs
    GET /v4/vpcs
    GET /v4/vpcs/{vpcId}
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@hana-akamai hana-akamai added the VPC Relating to VPC project label Mar 14, 2025
@hana-akamai hana-akamai self-assigned this Mar 14, 2025
@hana-akamai hana-akamai force-pushed the M3-9511-update-endpoints-and-types-VPC-Entity branch from e9ebcb1 to 854d458 Compare March 17, 2025 18:23
@hana-akamai hana-akamai marked this pull request as ready for review March 18, 2025 17:24
@hana-akamai hana-akamai requested a review from a team as a code owner March 18, 2025 17:24
@hana-akamai hana-akamai requested review from cpathipa, pmakode-akamai and dwiley-akamai and removed request for a team March 18, 2025 17:24
@hana-akamai hana-akamai force-pushed the M3-9511-update-endpoints-and-types-VPC-Entity branch from 7137618 to 9121a70 Compare March 19, 2025 15:40
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing538 Passing3 Skipped128m 53s

Details

Failing Tests
SpecTest
clone-linode.spec.tsclone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to API spec and this LGTM ✅

Can we get Upcoming Features changesets for api-v4 and validation?

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Mar 19, 2025
@hana-akamai hana-akamai merged commit 3a17852 into linode:develop Mar 19, 2025
24 of 25 checks passed
@hana-akamai hana-akamai deleted the M3-9511-update-endpoints-and-types-VPC-Entity branch March 19, 2025 21:12
@hana-akamai hana-akamai added VPC IPv6 Approved Multiple approvals and ready to merge! and removed VPC Relating to VPC project Add'tl Approval Needed Waiting on another approval! labels Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! VPC IPv6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants