-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking βSign up for GitHubβ, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-9535] - Support VPC interfaces on updated Linode Create Networking flow #11847
Merged
bnussman-akamai
merged 20 commits into
linode:develop
from
bnussman-akamai:M3-9534-support-vpc-in-add-network-connection-drawer
Mar 19, 2025
+462
β127
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
020c05c
add vpc field
bnussman 6dbb533
add subnet field
bnussman 295f00c
attempt to improve validation layre
bnussman 8383903
save progress
bnussman ecc443b
hopefully fix all typesafety issues
bnussman cdc5d70
things seems to be working
bnussman 68ff981
make sure legacy interfaces can be created safely
bnussman 056388f
improve UX a bit
bnussman 391d8a2
Merge branch 'develop' into M3-9534-support-vpc-in-add-network-connecβ¦
bnussman e1e76a2
continue working on validation
bnussman 450f87e
clean up tansformer function
bnussman a5d558d
add nicer validation errors
bnussman ffd9d14
Added changeset: Improved accuracy of schemas related to Linode creation
bnussman ff4395e
Added changeset: Initial support for VPCs using Linode Interfaces on β¦
bnussman 5fc42d0
Added changeset: Improved type-safety of Linode Create flow form
bnussman 42a3772
validate when values are populated from drawer
bnussman 499b744
use notices instead of helper text
bnussman 4bf1265
fix spelling
bnussman ad8acdd
Merge branch 'develop' into M3-9534-support-vpc-in-addt push or -netwβ¦
bnussman 6d02652
surface another error
bnussman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
things seems to be working
commit cdc5d70dccc78b52a88bd29e2a07079997136fb7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unchanged files with check annotations Beta
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const selectedVPC = vpcs?.find((vpc) => vpc.id === selectedVPCId); | ||
console.log(formState.errors) | ||
return ( | ||
<Box> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not intuitive to me, but this is how I had to handle an optional object with required fields.
Let me know if there is a better way to handle this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.notRequired().nullable()
maybe? (haven't tried)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue unfortunately
notRequired
includes nullable already https://github.com/jquense/yup?tab=readme-ov-file#schemanotrequired-schemaEither, way it doesn't work as I expect for optional object with required fields