upcoming: [M3-9421] - Add API endpoints and types for /v4/nodebalancers
#11832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endpoints for NB-VPC Integration
5 tasks
harsh-akamai
requested review from
bnussman-akamai and
coliu-akamai
and removed request for
a team
|
Coverage Report: ✅ |
| nodes: array() | ||
| .of(nodeBalancerConfigNodeSchema) | ||
| .required() | ||
| .min(1, 'You must provide at least one back end node.'), |
There was a problem hiding this comment.
we'll need a Validation changed changeset for this
There was a problem hiding this comment.
Removed this change since nodes are not a required field for updating configs, contrary to what the tech docs mention
…241-add-endpoints-in-nb
…h-akamai/manager into M3-9241-add-endpoints-in-nb
harsh-akamai
requested review from
dmcintyr-akamai
and removed request for
a team
harsh-akamai
force-pushed
the
M3-9241-add-endpoints-in-nb
branch
from
6e2aace to
aa17b47
Compare
harsh-akamai
commented
Mar 20, 2025
| @@ -235,7 +246,7 @@ export interface CreateNodeBalancerPayload { | |||
| configs: CreateNodeBalancerConfig[]; | |||
| firewall_id?: number; | |||
| tags?: string[]; | |||
| vpc?: { | |||
| vpcs?: { | |||
There was a problem hiding this comment.
Feedback from previous PR comment
Cloud Manager UI test results🎉 539 passing tests on test run #10 ↗︎
|
dwiley-akamai
approved these changes
Mar 20, 2025
coliu-akamai
approved these changes
Mar 20, 2025
| * | ||
| * @param nodeBalancerId { number } The ID of the NodeBalancer to view vpc config info for. | ||
| */ | ||
| export const getNodeBalancerVPCsBeta = ( |
There was a problem hiding this comment.
optional: wondering if these should be renamed to getNodeBalancerVPCConfigsBeta since we're getting VPC config data, not VPCs specifically?
either makes sense to me though, especially since the endpoint itself uses /vpcs, not /vpc-configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add new /v4/nodebalancers (& /v4beta/nodebalancers) endpoints for NB-VPC Integration
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅