-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-9105] - Add Account Default Firewalls setting #11828
Conversation
save progress
public_interface: number | null; | ||
vpc_interface: number | null; | ||
linode: number | null; | ||
nodebalancer: number | null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated types - when an account starts without defaults, these values come in as null
note: from what I'm seeing, omitting a field or setting it to null in the payload doesn't change the field in the DB/it doesn't reset it back to null. The API just keeps whatever's there, so once you update the default firewalls, there's no way to reset them w/o editing the DB directly. Reach out if you want to clear the defaults and are unsure of which db table to update |
Interesting. Good catch on that. @coliu-akamai You can't even delete the firewall to clear out the account default. 😳 In my option, users should be allowed to set the account defaults back to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Code is clean and readable 🧼
Feature works well when testing against our devenv instance ✅
If we convince the API to allow users to clear out the account defaults, we can come back and make necessary changes in the future
sounds good! will double check with them about clearing defaults also pushed up a small change to add success toasts for updating default firewalls/network interface type... not sure why but the button becoming disabled (as expected) suddenly started throwing me off and the toasts helped mitigate that. I can remove the toasts if we think it's too much / extra though! |
Coverage Report: ✅ |
See internal slack / Default Firewall API specs - they don't plan to let you reset once you've already chosen a firewall. This is so you can't go back on protection once you start having defaults - ig the only way to delete a firewall set as the default then is to select a new default |
Thanks for checking @coliu-akamai Makes sense! If I were a customer I might be super mad I'm not allowed to fully "clean up" my account anymore, but I guess it works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @coliu-akamai!
Cloud Manager UI test results🔺 2 failing tests on test run #10 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/firewalls/create-firewall.spec.ts,cypress/e2e/core/firewalls/delete-firewall.spec.ts" |
Note
The design is not fully finalized, but you can test that the form works (using devenv)
Once the design is updated, I'll implement it here before merging
Description 📝
Changes 🔄
DefaultFirewalls.tsx
,DefaultFirewalls.test.tsx
,GlobalSettings.tsx
; and then in all the other packagesPreview 📷
How to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅