Adding support for PrefixList APIs #839
Conversation
komer3
requested review from
Copilot,
vshanthe and
zliang-akamai
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for PrefixList APIs by implementing functionality to list and retrieve specific prefix lists from the Linode API.
- Introduces a new
PrefixListstruct with all necessary fields and custom JSON unmarshaling for timestamp handling - Adds
ListPrefixListsandGetPrefixListclient methods for API interaction - Provides comprehensive unit tests covering list, get, and JSON unmarshaling operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| prefixlists.go | Implements PrefixList struct, custom JSON unmarshaling, and client methods for listing and getting prefix lists |
| test/unit/prefixlists_test.go | Adds comprehensive unit tests for PrefixList operations including list, get, and JSON unmarshaling scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@komer3 Is there any chance you could re-point this PR at the |
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Implementation looks good and I verified that all changes align with the API specification. Thank you for the contribution!
| type PrefixList struct { | ||
| ID int `json:"id"` | ||
| Name string `json:"name"` | ||
| Description string `json:"description,omitempty"` |
There was a problem hiding this comment.
omitempty is not necessary in a resource struct which won't be used in an API request body.
| Description string `json:"description,omitempty"` | |
| Description string `json:"description"` |
| type PrefixList struct { | ||
| ID int `json:"id"` | ||
| Name string `json:"name"` | ||
| Description string `json:"description,omitempty"` | ||
| Visibility string `json:"visibility"` | ||
| SourcePrefixListID *int `json:"source_prefixlist_id"` | ||
| IPv4 *[]string `json:"ipv4"` | ||
| IPv6 *[]string `json:"ipv6"` | ||
| Version int `json:"version"` | ||
|
|
||
| Created *time.Time `json:"-"` | ||
| Updated *time.Time `json:"-"` | ||
| Deleted *time.Time `json:"-"` | ||
| } |
There was a problem hiding this comment.
customer_id seems to be missed here?
3 participants
📝 Description
What does this PR do and why is this change necessary?
Adding support for listing and getting specific PrefixList APIs
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
Added relevant unit tests (no integration since API is not currently available). Just run
make testto verfiy📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.