Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and LinkML version #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vincentkelleher
Copy link

@vincentkelleher vincentkelleher commented Dec 24, 2024

While I was working on a LinkML model update, I noticed that the pyyaml version in the Poetry lock file had a known bug and that the LinkML dependencies were outdated.

I started by updating the Poetry lock file to retrieve the latest versions of the dependencies but this caused an issue with default values in the meta.yaml file as LinkML generators now raise an error when the default value isn't valid.

I then set out to fix those default values. I noticed that these default values were just ignored by the previous versions of the LinkML generator as they would fail silently so I removed them which doesn't have any effect on the generated output from what I saw.

This is a bold change so I need all the pairs of eyes I can get on this 😄

PS: this also allows the usage of Python 3.12 😇

Signed-off-by: Vincent Kelleher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant