Refactor CCKafkaClientsIntegrationTestHarness and dependent classes.#2337
Open
kyguy wants to merge 1 commit intolinkedin:mainfrom
Open
Refactor CCKafkaClientsIntegrationTestHarness and dependent classes.#2337kyguy wants to merge 1 commit intolinkedin:mainfrom
kyguy wants to merge 1 commit intolinkedin:mainfrom
Conversation
Signed-off-by: Kyle Liberti <kliberti.us@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why: This PR is the fourth iteration of the TestContainers migration following the initial migration Migrate CruiseControlMetricsReporterTest to TestContainers #2303 in effort to remove the Cruise Control tests dependence on internal Kafka APIs. As detailed in issue Migrate off internal Kafka APIs to Improve Compatibility and Maintainability Migrate off internal Kafka APIs to Improve Compatibility and Maintainability #2282, the existing Cruise Control tests rely on the Kafka server wrapper class,
CCEmbeddedBroker, which uses several non-public Kafka APIs. These internal APIs lack stability and compatibility guarantees, making it increasingly difficult to upgrade Kafka versions. As Kafka evolves, this reliance introduces upgrade friction, version lock-in, and a growing maintenance burden.What: This PR is the next step of the TestContainers migration following this Migrate CruiseControlMetricsReporterTest to TestContainers #2303. It refactors the CCKafkaClientsIntegrationTestHarness and dependent classes to replace the dependency on the
CCEmbeddedBrokerclass with the TestContainers Kafka module instead. This helps future-proof Cruise Control by easing upgrades to newer Kafka versions, expanding Kafka versions compatibility, and reducing the ongoing maintenance overhead.Categorization
This PR partially resolves #2282.