Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple schema parsing from code generation #532

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

karthikrg
Copy link
Contributor

Decouple schema parsing (fast) from code generation (slow) to be able to run avro codegen and plugins in parallel.
Remove dead code in SpecificRecordGenerator by following IDE warnings.

@codecov-commenter
Copy link

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (39d884c) 45.99% compared to head (7e0de3a) 46.00%.

Files Patch % Lines
.../operations/codegen/own/AvroUtilCodeGenPlugin.java 69.23% 14 Missing and 10 partials ⚠️
...vroutil1/codegen/SpecificRecordClassGenerator.java 84.00% 1 Missing and 3 partials ⚠️
...vroutil1/builder/plugins/BuilderPluginContext.java 80.00% 2 Missing ⚠️
...s/codegen/own/AvroUtilOperationContextBuilder.java 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #532   +/-   ##
=========================================
  Coverage     45.99%   46.00%           
+ Complexity     4487     4486    -1     
=========================================
  Files           405      406    +1     
  Lines         28140    28129   -11     
  Branches       4635     4631    -4     
=========================================
- Hits          12943    12940    -3     
+ Misses        13641    13633    -8     
  Partials       1556     1556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaoyu-yang-gh xiaoyu-yang-gh merged commit cdf7f90 into linkedin:master Jan 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants